Update README and add Dockerfile #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techno-coder
force-pushed
the
add-docker
branch
from
6671709 to
ed87856
Compare
bagedevimo
reviewed
Feb 16, 2023
| # Execution invocation: | ||
| # Privileged mode is required for control groups | ||
| # Must be invoked with '--network host' for port exposure | ||
| # docker run --privileged --network host -it nztrain:latest |
There was a problem hiding this comment.
-p / --expose should also be suitable no?
| rm /var/run/redis/redis.pid; \ | ||
| service postgresql stop | ||
|
|
||
| CMD service redis start; \ |
There was a problem hiding this comment.
IMO we are better to run redis/postgres outside this container and tell the app where to find them via env vars - in host and bridge (default iirc) - means this script can be vastly simplified and we can take advantsge oh GH actions having coomunity support for booting these services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
Dockerfilefor building under Docker. TheREADME.rdochas been updated to reflect building under Docker or manually.