Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change local development port to 5050 and record change in docs #288

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

Apophenia
Copy link
Contributor

MacOS Monterey introduced a new AirPlay feature enabled by default which uses port 5000. While the feature can be disabled, freeing up the port, the port cannot be changed and will continue to conflict with default settings of Flask, Node, and some PSGI/Perl dev servers. While we unfortunately can't fix this, we can change the default port of the project to 5050.

I spent some time attempting to abstract this into an environment variable, but drew a blank about how to dynamically change the port forwarding in the docker-compose setup. Changing the hard-coded values was a relatively straightfoward fix by comparison, but I am open to suggestions about how to assign and open this port dynamically and keep it working with the Docker setup.

@Apophenia Apophenia marked this pull request as ready for review February 1, 2024 19:41
Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think hard coding this for the time being works especially if it doesn't negatively affect the project in a major way. We can come back to this to dynamically change the port, but this is the best solution for now.

@Apophenia
Copy link
Contributor Author

Also tagging @ayan1229, @jackiequach, and @clarissarichard for transparency - once this is merged, the default port for DRB's API when running locally specifically will be 5050 instead of 5000, so any saved tests in Insomnia, Postman, etc may need to be updated.

@Apophenia Apophenia merged commit 1f9d10d into main Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants