Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-1866_Bardo&HathiConfigUpdate #283

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

mitri-slory
Copy link
Contributor

This PR updates the Bardo CCE API and Hathi Data Files URLS in the production and qa config. The Bardo CCE API URL was outdated so local running of the NYPL Process was unsuccessful and worked soon after updating this url.

@mitri-slory mitri-slory requested a review from Apophenia January 11, 2024 19:54
@mwbenowitz mwbenowitz temporarily deployed to Tugboat January 11, 2024 19:54 Destroyed
Copy link
Contributor

@Apophenia Apophenia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Is there any (external or internal) listing of the Bardo CCE API URL, so that if it changed again, we would know to update it?

@mitri-slory
Copy link
Contributor Author

There are no listings for the Bardo CCE API URL.

@mitri-slory mitri-slory merged commit 100088b into main Jan 17, 2024
2 of 3 checks passed
@mitri-slory mitri-slory deleted the SFR-1866_BardoCCE&HathiDataFilesURLUpdate branch January 17, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants