Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.3.2 #292

Merged
merged 69 commits into from
Feb 13, 2025
Merged

Release 0.3.2 #292

merged 69 commits into from
Feb 13, 2025

Conversation

7emansell
Copy link
Collaborator

[0.3.2] 2025-02-13

Added

  • Added custom searchbar to handle search submit
  • Added new search context and searchManager class, implemented on /collections page (DR-3365)

Updated

  • Updated 3rd party scripts with explicit loading strategies (DR-3376)

@7emansell
Start
a5b04c7
@7emansell
more commenting
fe884a7
@7emansell
Bringing spike code over
b365167
@7emansell
All spike code moved over, working
c6081df
@7emansell
Splitting up search manager class
cadb0e8
@7emansell
Can we remove this #collections
d8b587f
@7emansell
Adding firstIndexed to reflect collections api
57d2b21
@7emansell
Did i just fix our loading state
976ab38
@7emansell
cleaning up parameter names
5f63988
@7emansell
Tests for provider and search manager
4e821f2
@7emansell
Setting it up for search/index to confirm context works
0a48664
@7emansell
Updating page tests
a2b9b1b
@7emansell
Accidentally broke no results
6488aee
@7emansell
More corrections for search page
bf3f15c
@7emansell
Fixing mocks
e8b65d4
@7emansell
going through search manager again
c78cd22
@7emansell
making filters optional
3c041ef
@7emansell
unnecessary set to false
1c4ddf0
@7emansell
setISLoaded for only non keyword
b8c6171
@7emansell
more notes
ad0ee32
@7emansell
mainly questions
8f9abdc
@7emansell
Adding suspense to see if it helps
8519c47
@7emansell
back to isloaded
a35b3bb
@7emansell
collections schema from feb 3
fdbe211
@7emansell
notes
29e90e2
@7emansell
more notes
b4dde90
@7emansell
and more
be998ca
@7emansell
Adjusting to reflect collections API format
a426e79
@7emansell
Clean up
0cacdb9
@7emansell
Adding comment to getSearchData
77afc22
@7emansell
Matching old search bars
be9d830
@7emansell
flag and changelog
94e3828
@7emansell
Merge branch 'DR-3365/search-for-collections' into no_ref/dc-searchbar
b4539b9
@7emansell
Clean up
0158b13
@7emansell
Correcting focus management as well
e4790ad
@7emansell
Updating aria labels and -labelledBy
98fcddb
@7emansell
Consistent naming of search props
accc713
@7emansell
Updating test
c9c025a
@7emansell
Merge branch 'DR-3365/search-for-collections' into no_ref/dc-searchbar
bae8c03
@7emansell
Removing unnecessary factory and updating tests
74e97c2
@7emansell
Collections children schema
08eb00d
@7emansell
Merge pull request #287 from NYPL/no_ref/dc-searchbar
c56c300 
No ref: DC custom search bar
@7emansell
Merge pull request #286 from NYPL/DR-3365/search-for-collections
ebbaa61 
DR-3365: Implement search approach for `/collections`
@7emansell
Bug fix with repeating data
5b321d4
@7emansell
And aria-labelledby typo
c8963c0
@7emansell
Adding afterInteractive to footer
b854ea2
@7emansell
lazyOnload
cac600a
@7emansell
Merge pull request #282 from NYPL/DR-3395/collection-schema
a62ffb9 
DR-3395: `collections/:uuid` schema
@7emansell
Well
c325b3c
@7emansell
changelog
ef37713
@7emansell
Merge pull request #289 from NYPL/DR-3376/optimize-scripts
508cb05 
DR-3376: Optimize third party scripts
@7emansell
Updating package version and changelog
b6bed25
@vercel Vercel
Copy link

vercel bot commented Feb 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
digital-collections ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:23pm

@7emansell 7emansell changed the base branch from main to production February 13, 2025 17:22
EdwinGuzman
EdwinGuzman approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@7emansell 7emansell merged commit b6bed25 into production Feb 13, 2025
4 checks passed
@7emansell 7emansell deleted the release/0.3.2 branch February 13, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdwinGuzman EdwinGuzman EdwinGuzman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@7emansell @EdwinGuzman