Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add USD Material import support #502

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Add USD Material import support #502

merged 1 commit into from
Dec 20, 2021

Conversation

Jean-Francois-Lafleche
Copy link
Contributor

gh_img
left: input, right: import/export using Kaolin (excluding transparent materials)

NOTE: Breaking API changes

Details

  • Add with_normals and with_materials flags
  • Correct behaviour of face_uvs_idxduring import/export for faceVarying interpolation with no indices
  • Add MaterialManager to allow registration of new materials that can be automatically imported
  • Improve PBRMaterial and Material base class API
  • Improve error handling during material read
  • Various bug fixes

Caenorst
Caenorst approved these changes Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@Caenorst Caenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Caenorst Caenorst merged commit 5d55562 into NVIDIAGameWorks:master Dec 20, 2021
orperel pushed a commit to orperel/kaolin that referenced this pull request Jan 11, 2022
@Jean-Francois-Lafleche
Add USD Material import support (NVIDIAGameWorks#502)
c96f480 
Signed-off-by: JF Lafleche <[email protected]>
orperel pushed a commit to orperel/kaolin that referenced this pull request Jan 11, 2022
Revert "Add USD Material import support (NVIDIAGameWorks#502)"
6cec5d0 
This reverts commit c96f480.
zookae pushed a commit to zookae/kaolin that referenced this pull request Mar 30, 2022
@Jean-Francois-Lafleche @zookae
Add USD Material import support (NVIDIAGameWorks#502)
932b9a0 
Signed-off-by: JF Lafleche <[email protected]>
Signed-off-by: Alex Zook <[email protected]>
zookae pushed a commit to zookae/kaolin that referenced this pull request Mar 30, 2022
@Jean-Francois-Lafleche @zookae
Add USD Material import support (NVIDIAGameWorks#502)
abb1925 
Signed-off-by: JF Lafleche <[email protected]>
Signed-off-by: Alex Zook <[email protected]>
zookae pushed a commit to zookae/kaolin that referenced this pull request Mar 30, 2022
@Jean-Francois-Lafleche @zookae
Add USD Material import support (NVIDIAGameWorks#502)
cb42aa7 
Signed-off-by: JF Lafleche <[email protected]>
Signed-off-by: Alex Zook <[email protected]>
zookae pushed a commit to zookae/kaolin that referenced this pull request Mar 31, 2022
@Jean-Francois-Lafleche @zookae
Add USD Material import support (NVIDIAGameWorks#502)
d07da10 
Signed-off-by: JF Lafleche <[email protected]>
Signed-off-by: Alex Zook <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caenorst Caenorst Caenorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jean-Francois-Lafleche @Caenorst