Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depth outputs from SPC raytracing, slight API refactor, fix raytrace AABB behaviour #478

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Add depth outputs from SPC raytracing, slight API refactor, fix raytrace AABB behaviour #478

merged 1 commit into from
Dec 1, 2021

Conversation

tovacinni
Copy link
Collaborator

Summary of changes:

  • mark_first_hits is now mark_pack_boundary which a more general packed operation.
  • SPC raytrace can now return depth. This deprecates the need for the old ray_aabb function.
  • Some edge cases in raytracing is handled differently now. Before, rays could miss if they are exactly between 2 voxels, but now it will hit both.
  • raytrace will now return 2 tensors, the ray index and the point hierarchy index. Previously these 2 tensors were stored as a single tensor, which was confusing.
  • Other misc enhancements and fixes.

This also addresses #463 .

@tovacinni tovacinni requested a review from Caenorst December 1, 2021 01:56
Copy link
Collaborator

@Caenorst Caenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@Caenorst Caenorst merged commit d387158 into NVIDIAGameWorks:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants