This repository was archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 756
WIP: Remove legacy code for things we do not support #1152
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brycelelbach
commented
May 16, 2020
- Remove C++03 codepaths.
- Remove SM < 30.
- Remove GCC < 5 codepaths.
- Remove MSVC < 2017 codepaths.
- Remove Clang < 6 codepaths.
- Remove any other dead code for things we don't support.
* Remove C++03 codepaths. * Remove SM < 30. * Remove GCC < 5 codepaths. * Remove MSVC < 2017 codepaths. * Remove Clang < 6 codepaths. * Remove any other dead code for things we don't support.
alliepiper
reviewed
May 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alliepiper
reviewed
May 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds clean and tests pass with the pushed changes (squash them in if you're good with them)
alliepiper
suggested changes
May 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added another fix-up commit -- some tests were including retag.h
.
Ran this through my screening tests and found some failures on C++17 configs:
It looks like it is only on the non-cuda builds:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.