Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valid retry solution to mvn-verify [skip ci] #9609

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Add valid retry solution to mvn-verify [skip ci] #9609

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b672a7
add retry in bash-level
YanxuanLiu Nov 2, 2023
136c0f2
for test
YanxuanLiu Nov 2, 2023
857d244
change format of while
YanxuanLiu Nov 2, 2023
abe4d7b
remove line break of COMMON_MVN_FLAGS
YanxuanLiu Nov 2, 2023
9115e02
add retry and ttl config for all stages
YanxuanLiu Nov 3, 2023
8f15a4d
using increamental delay
YanxuanLiu Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 64 additions & 27 deletions .github/workflows/mvn-verify-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ concurrency:
cancel-in-progress: true

env:
COMMON_MVN_FLAGS: >
COMMON_MVN_FLAGS: >-
-Ddist.jar.compress=false
-DskipTests
-Dskip
Expand Down Expand Up @@ -124,14 +124,22 @@ jobs:
export JAVA_HOME=${JAVA_HOME_8_X64}
export PATH=${JAVA_HOME}/bin:${PATH}
java -version && mvn --version && echo "ENV JAVA_HOME: $JAVA_HOME, PATH: $PATH"
# test command
mvn -Dmaven.wagon.http.retryHandler.count=3 -B package \
-pl integration_tests,tests -am \
-P 'individual,pre-merge' \
-Dbuildver=${{ matrix.spark-version }} \
-Dmaven.scalastyle.skip=true \
-Drat.skip=true \
${{ env.COMMON_MVN_FLAGS }}
# test command, will retry for 3 times if failed.
max_retry=3; delay=30; i=1
while true; do
mvn -Dmaven.wagon.http.retryHandler.count=3 \
-Dmaven.wagon.httpconnectionManager.ttlSeconds=30 \
-Daether.connector.http.connectionMaxTtl=30 -B package \
-pl integration_tests,tests -am -P 'individual,pre-merge' \
-Dbuildver=${{ matrix.spark-version }} -Dmaven.scalastyle.skip=true \
-Drat.skip=true ${{ env.COMMON_MVN_FLAGS }} && break || {
if [[ $i -le $max_retry ]]; then
echo "mvn command failed. Retry $i/$max_retry."; ((i++)); sleep $delay; ((delay=delay*2))
else
echo "mvn command failed. Exit 1"; exit 1
fi
}
done

package-tests-scala213:
needs: get-shim-versions-from-dist
Expand Down Expand Up @@ -170,14 +178,22 @@ jobs:
fi
# change to Scala 2.13 Directory
cd scala2.13
# test command
mvn -Dmaven.wagon.http.retryHandler.count=3 -B package \
-pl integration_tests,tests -am \
-P 'individual,pre-merge' \
-Dbuildver=${{ matrix.spark-version }} \
-Dmaven.scalastyle.skip=true \
-Drat.skip=true \
${{ env.COMMON_MVN_FLAGS }}
# test command, will retry for 3 times if failed.
max_retry=3; delay=30; i=1
while true; do
mvn -Dmaven.wagon.http.retryHandler.count=3 \
-Dmaven.wagon.httpconnectionManager.ttlSeconds=30 \
-Daether.connector.http.connectionMaxTtl=30 -B package \
-pl integration_tests,tests -am -P 'individual,pre-merge' \
-Dbuildver=${{ matrix.spark-version }} -Dmaven.scalastyle.skip=true \
-Drat.skip=true ${{ env.COMMON_MVN_FLAGS }} && break || {
if [[ $i -le $max_retry ]]; then
echo "mvn command failed. Retry $i/$max_retry."; ((i++)); sleep $delay; ((delay=delay*2))
else
echo "mvn command failed. Exit 1"; exit 1
fi
}
done


verify-all-modules:
Expand Down Expand Up @@ -206,11 +222,21 @@ jobs:
export JAVA_HOME=${JAVA_HOME_${{ matrix.java-version }}_X64}
export PATH=${JAVA_HOME}/bin:${PATH}
java -version && mvn --version && echo "ENV JAVA_HOME: $JAVA_HOME, PATH: $PATH"
# test command
mvn -Dmaven.wagon.http.retryHandler.count=3 -B verify \
-P "individual,pre-merge" \
-Dbuildver=${{ matrix.spark-version }} \
${{ env.COMMON_MVN_FLAGS }}
# test command, will retry for 3 times if failed.
max_retry=3; delay=30; i=1
while true; do
mvn -Dmaven.wagon.http.retryHandler.count=$max_retry \
-Dmaven.wagon.httpconnectionManager.ttlSeconds=30 \
-Daether.connector.http.connectionMaxTtl=30 -B verify \
-P "individual,pre-merge" -Dbuildver=${{ matrix.spark-version }} \
${{ env.COMMON_MVN_FLAGS }} && break || {
if [[ $i -le $max_retry ]]; then
echo "mvn command failed. Retry $i/$max_retry."; ((i++)); sleep $delay; ((delay=delay*2))
else
echo "mvn command failed. Exit 1"; exit 1
fi
}
done

install-modules:
needs: get-shim-versions-from-dist
Expand Down Expand Up @@ -242,8 +268,19 @@ jobs:
export JAVA_HOME=export JAVA_HOME=${JAVA_HOME_11_X64}
export PATH=${JAVA_HOME}/bin:${PATH}
java -version && mvn --version && echo "ENV JAVA_HOME: $JAVA_HOME, PATH: $PATH"
# test command
./mvnw -Dmaven.wagon.http.retryHandler.count=3 -B install \
-P "individual,pre-merge" \
-Dbuildver=${{ needs.get-shim-versions-from-dist.outputs.defaultSparkVersion }} \
${{ env.COMMON_MVN_FLAGS }}
# test command, will retry for 3 times if failed.
max_retry=3; delay=30; i=1
while true; do
./mvnw -Dmaven.wagon.http.retryHandler.count=3 \
-Dmaven.wagon.httpconnectionManager.ttlSeconds=30 \
-Daether.connector.http.connectionMaxTtl=30 -B install \
-P "individual,pre-merge" \
-Dbuildver=${{ needs.get-shim-versions-from-dist.outputs.defaultSparkVersion }} \
${{ env.COMMON_MVN_FLAGS }} && break || {
if [[ $i -le $max_retry ]]; then
echo "mvn command failed. Retry $i/$max_retry."; ((i++)); sleep $delay; ((delay=delay*2))
else
echo "mvn command failed. Exit 1"; exit 1
fi
}
done