Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry for CrossJoinIterator and ConditionalNestedLoopJoinIterator #9572

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Add retry for CrossJoinIterator and ConditionalNestedLoopJoinIterator #9572

merged 1 commit into from
Oct 31, 2023

Conversation

firestarman
Copy link
Collaborator

@firestarman firestarman commented Oct 30, 2023 •
edited
Loading

fixes #8344
fixes #8345

This PR adds retry support to creating the gather maps for CrossJoinIterator and the computeNumJoinRows method
of ConditionalNestedLoopJoinIterator.

This is simple enough so I don't add tests. If you prefer I am happy to try to add some.

@firestarman
Copy link
Collaborator Author

build

revans2
revans2 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The tests should be covered by the random OOM injection testing that we already do.

jbrennan333
jbrennan333 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm

@firestarman firestarman merged commit 7bd0998 into NVIDIA:branch-23.12 Oct 31, 2023
@firestarman firestarman deleted the retry-cross-join branch October 31, 2023 03:18
@sameerz sameerz added the reliability Features to improve reliability or bugs that severly impact the reliability of the plugin label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winningsix winningsix winningsix approved these changes

@revans2 revans2 revans2 approved these changes

@jbrennan333 jbrennan333 jbrennan333 approved these changes

Assignees
No one assigned
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Milestone
No milestone
5 participants
@firestarman @winningsix @revans2 @jbrennan333 @sameerz