Add Apache Spark 3.3.0-SNAPSHOT Shims #4012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
gerashegalov
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
gerashegalov
changed the title
Signed-off-by: Gera Shegalov <[email protected]>
|
build |
Signed-off-by: Gera Shegalov <[email protected]>
jlowe
reviewed
Nov 3, 2021
tgravescs
reviewed
Nov 3, 2021
.../src/main/301until330-all/scala/com/nvidia/spark/rapids/shims/v2/Spark30Xuntil32XShims.scala
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
|
|
.../src/main/301until330-all/scala/com/nvidia/spark/rapids/shims/v2/Spark30Xuntil32XShims.scala
Outdated
Show resolved
Hide resolved
.../src/main/301until330-all/scala/com/nvidia/spark/rapids/shims/v2/Spark30Xuntil32XShims.scala
Outdated
Show resolved
Hide resolved
| @@ -63,7 +63,7 @@ case class GpuOrcScan( | |||
| super.description() + ", PushedFilters: " + seqToString(pushedFilters) | |||
| } | |||
|
|
|||
| override def withFilters( | |||
| def withFilters( | |||
There was a problem hiding this comment.
so I think this is bad, meaning Spark changed this in SPARK-36351 and isn't calling withFilters anymore in 3.3.0. This implies we might not be getting the filters applied in Spark 3.3.0 because we don't implement the new api.
We need to at least file a follow on for this and point to both SPARK-36351 and this change to investigate to make sure we don't need to use those new API.
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/metrics/source/MockTaskContext.scala
Show resolved
Hide resolved
Signed-off-by: Gera Shegalov <[email protected]>
|
build |
tgravescs
approved these changes
Nov 3, 2021
jlowe
approved these changes
Nov 3, 2021
|
cc @pxLi |
gerashegalov
changed the title
thanks, I will add a nightly pipeline for spark33x~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3863
Closes #3954
Signed-off-by: Gera Shegalov [email protected]