Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GPU-unsupported \z with an alternative RLIKE expression #10090

Merged
merged 5 commits into from
Dec 26, 2023
Merged

Replace GPU-unsupported \z with an alternative RLIKE expression #10090

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8d43f8e
Don't use \\z
gerashegalov Dec 21, 2023
12aefc0
fixes #9992
gerashegalov Dec 21, 2023
2e34da1
Restore SQL
gerashegalov Dec 21, 2023
8999a0b
Merge remote-tracking branch 'origin/branch-24.02' into gerashegalov/…
gerashegalov Dec 21, 2023
8744364
restore [0-9]
gerashegalov Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions integration_tests/src/main/python/conditionals_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def test_coalesce(data_gen):
s1 = with_cpu_session(
lambda spark: gen_scalar(data_gen, force_no_nulls=not isinstance(data_gen, NullGen)))
# we want lots of nulls
gen = StructGen([('_c' + str(x), data_gen.copy_special_case(None, weight=1000.0))
gen = StructGen([('_c' + str(x), data_gen.copy_special_case(None, weight=1000.0))
for x in range(0, num_cols)], nullable=False)
command_args = [f.col('_c' + str(x)) for x in range(0, num_cols)]
command_args.append(s1)
Expand Down Expand Up @@ -214,7 +214,7 @@ def test_conditional_with_side_effects_cast(data_gen):
ansi_enabled_conf, {'spark.rapids.sql.regexp.enabled': True})
assert_gpu_and_cpu_are_equal_collect(
lambda spark : unary_op_df(spark, data_gen).selectExpr(
'IF(a RLIKE "^[0-9]{1,5}\\z", CAST(a AS INT), 0)'),
'IF(a RLIKE "^[0-9]{5,}", CAST(SUBSTR(a, 0, 5) AS INT), 0)'),
conf = test_conf)

@pytest.mark.parametrize('data_gen', [mk_str_gen('[0-9]{1,9}')], ids=idfn)
Expand All @@ -225,8 +225,8 @@ def test_conditional_with_side_effects_case_when(data_gen):
assert_gpu_and_cpu_are_equal_collect(
lambda spark : unary_op_df(spark, data_gen).selectExpr(
'CASE \
WHEN a RLIKE "^[0-9]{1,3}\\z" THEN CAST(a AS INT) \
WHEN a RLIKE "^[0-9]{4,6}\\z" THEN CAST(a AS INT) + 123 \
WHEN a RLIKE "^[0-9]{6}" THEN CAST(SUBSTR(a, 0, 6) AS INT) + 123 \
WHEN a RLIKE "^[0-9]{3}" THEN CAST(SUBSTR(a, 0, 3) AS INT) \
ELSE -1 END'),
conf = test_conf)

Expand Down