Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mil meta collect #494

Merged
merged 8 commits into from
Mar 3, 2025
Merged

Mil meta collect #494

merged 8 commits into from
Mar 3, 2025

Conversation

jperez999
Copy link
Collaborator

@jperez999 jperez999 commented Feb 27, 2025 •
edited
Loading

Description

This PR adds the milvus meta collection logic, which store information about all collections created for nv-ingest. And it provides an api for quering against that collection to get information about specific collections recorded.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jperez999 jperez999 added the feature request New feature or request label Feb 27, 2025
@jperez999 jperez999 self-assigned this Feb 27, 2025
@jperez999 jperez999 requested a review from a team as a code owner February 27, 2025 01:16
@jperez999 jperez999 requested review from jdye64 and removed request for a team February 27, 2025 01:16
@jperez999 jperez999 requested a review from a team February 27, 2025 01:17
ChrisJar
ChrisJar approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@ChrisJar ChrisJar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jperez999 jperez999 merged commit 959598f into NVIDIA:main Mar 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJar ChrisJar ChrisJar approved these changes

@jdye64 jdye64 Awaiting requested review from jdye64 jdye64 is a code owner automatically assigned from NVIDIA/nv-ingest-maintainers

Assignees

@jperez999 jperez999

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jperez999 @ChrisJar