Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Update atomics backend to be compatible with atomic_ref. #379

Merged
merged 6 commits into from
Feb 28, 2023
Merged

Update atomics backend to be compatible with atomic_ref. #379

merged 6 commits into from
Feb 28, 2023

Conversation

wmaxey
Copy link
Member

@wmaxey wmaxey commented Feb 28, 2023

No description provided.

@wmaxey wmaxey requested a review from griwes February 28, 2023 02:43
@wmaxey wmaxey mentioned this pull request Feb 28, 2023
Closed
@wmaxey wmaxey added the P0: must have Absolutely must ship with the milestone. label Feb 28, 2023
miscco
miscco approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of the naming in this header, but that is something for another day

miscco
miscco reviewed Feb 28, 2023
View reviewed changes
...omics/atomics.types.operations/atomics.types.operations.wait/atomic_ref_member_wait.pass.cpp Outdated
#endif
T * t;
#ifdef __CUDA_ARCH__
if (threadIdx.x == 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not really work because it lets a get out of scope

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with latest commit:

6378179

@wmaxey wmaxey merged commit f0e40d5 into main Feb 28, 2023
@wmaxey wmaxey deleted the feature/atomic_ref_wait branch February 28, 2023 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miscco miscco miscco approved these changes

@griwes griwes Awaiting requested review from griwes

Assignees
No one assigned
Labels
P0: must have Absolutely must ship with the milestone.
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmaxey @miscco