Add multiarch

[ArangoGutierrez]

Needed for devel on Mac MX

[elezar]

I don't believe that this will push the multi-arch image.

[ArangoGutierrez]

yeah, I am looking how to

[elezar]

Note that for multi-arch images we use docker buildx and add the:

--output=type=image,push=$(PUSH_ON_BUILD)

flags to ensure that the multiarch image is pushed to the repo.

[elezar]

For example, for the device plugin (note that the command below has push=false specified)

DOCKER_BUILDKIT=1 \
        docker buildx build --pull \
        --output=type=image,push=false \
        --platform=linux/amd64,linux/arm64 \
        --tag nvcr.io/nvidia/k8s-device-plugin:v0.14.3-ubuntu20.04 \
        --build-arg BASE_DIST="ubuntu20.04" \
        --build-arg CUDA_VERSION="12.3.0" \
        --build-arg GOLANG_VERSION="1.20.5" \
        --build-arg VERSION="v0.14.3" \
        --build-arg GIT_COMMIT="2bef25804caf5924f35a164158f097f954fe4c74-dirty" \
         \
        -f /Users/elezar/src/device-plugin/deployments/container/Dockerfile.ubuntu \
        /Users/elezar/src/device-plugin

[elezar]

Is there any value in separating the build and push jobs if the only different should be:

 push: false

vs

 push: true

(and possibly the architecture?)

Or could you better describe the interaction between the two jobs?

[ArangoGutierrez]

Is there any value in separating the build and push jobs if the only different should be:

 push: false

vs

 push: true

(and possibly the architecture?)

Or could you better describe the interaction between the two jobs?

The just build, only build major X.X go version and on the default platform, not to waste time on building the big matrix.
Once the PR is in, the PUSH action, will build on arm and amd64 and on all the required go versions x.y.z

[elezar]

OK. That's fair. My concern is drift between the two jobs. Could we construct the matrix conditionally as per https://stackoverflow.com/questions/65384420/how-do-i-make-a-github-action-matrix-element-conditional (as well as push=true) and reuse the same step definition?

It seems as if using excludes (also in one of the solutions proposed in the linked page) could also do what we want:

strategy:
  matrix:
    fruits:
      - apple
      - banana
    exclude:
      - fruits: ${{ github.ref == 'refs/heads/main' && 'dummy' || 'apple' }}
      - fruits: ${{ (github.event_name != 'pull_request' || (github.event_name == 'pull_request' && contains( github.event.pull_request.labels.*.name, 'BUILD-BANANA'))) && 'dummy' || 'banana' }}

To be clear, I don't feel too strongly about this.

[elezar]

I still feel that we should reevaluate reusing the steps more to not have to update these in multiple places, but I don't see this as a blocker for moving forward in other projects.

Feel free to merge this to unblock and revisit the refactor in a follow-up.