Skip to content

Commit

Permalink
[GDS][GDRCopy] remove unnecessary liveness probe
Browse files Browse the repository at this point in the history
Signed-off-by: Tariq Ibrahim <[email protected]>
  • Loading branch information
tariq1890 committed Mar 6, 2025
1 parent 6aeea0d commit 5bc4874
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 69 deletions.
18 changes: 0 additions & 18 deletions assets/state-driver/0500_daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -212,15 +212,6 @@ spec:
successThreshold: 1
periodSeconds: 10
timeoutSeconds: 10
livenessProbe:
exec:
command:
[sh, -c, 'lsmod | grep nvidia_fs']
periodSeconds: 30
initialDelaySeconds: 30
failureThreshold: 1
successThreshold: 1
timeoutSeconds: 10
- image: "FILLED BY THE OPERATOR"
imagePullPolicy: IfNotPresent
name: nvidia-gdrcopy-ctr
Expand Down Expand Up @@ -248,15 +239,6 @@ spec:
successThreshold: 1
periodSeconds: 10
timeoutSeconds: 10
livenessProbe:
exec:
command:
[sh, -c, 'lsmod | grep gdrdrv']
periodSeconds: 30
initialDelaySeconds: 30
failureThreshold: 1
successThreshold: 1
timeoutSeconds: 10
# Only kept when OpenShift DriverToolkit side-car is enabled.
- image: "FILLED BY THE OPERATOR"
imagePullPolicy: IfNotPresent
Expand Down
11 changes: 0 additions & 11 deletions internal/state/testdata/golden/driver-gdrcopy-openshift.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -281,17 +281,6 @@ spec:
- ocp_dtk_entrypoint
image: nvcr.io/nvidia/cloud-native/gdrdrv:v2.4.1-rhcos4.13
imagePullPolicy: IfNotPresent
livenessProbe:
exec:
command:
- sh
- -c
- lsmod | grep gdrdrv
failureThreshold: 1
initialDelaySeconds: 30
periodSeconds: 30
successThreshold: 1
timeoutSeconds: 10
name: nvidia-gdrcopy-ctr
securityContext:
privileged: true
Expand Down
11 changes: 0 additions & 11 deletions internal/state/testdata/golden/driver-gdrcopy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -209,17 +209,6 @@ spec:
- -xc
image: nvcr.io/nvidia/cloud-native/gdrdrv:v2.4.1
imagePullPolicy: IfNotPresent
livenessProbe:
exec:
command:
- sh
- -c
- lsmod | grep gdrdrv
failureThreshold: 1
initialDelaySeconds: 30
periodSeconds: 30
successThreshold: 1
timeoutSeconds: 10
name: nvidia-gdrcopy-ctr
securityContext:
privileged: true
Expand Down
11 changes: 0 additions & 11 deletions internal/state/testdata/golden/driver-gds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -209,17 +209,6 @@ spec:
- -xc
image: nvcr.io/nvidia/cloud-native/nvidia-fs:2.16.1
imagePullPolicy: IfNotPresent
livenessProbe:
exec:
command:
- sh
- -c
- lsmod | grep nvidia_fs
failureThreshold: 1
initialDelaySeconds: 30
periodSeconds: 30
successThreshold: 1
timeoutSeconds: 10
name: nvidia-fs-ctr
securityContext:
privileged: true
Expand Down
18 changes: 0 additions & 18 deletions manifests/state-driver/0500_daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -457,15 +457,6 @@ spec:
successThreshold: 1
periodSeconds: 10
timeoutSeconds: 10
livenessProbe:
exec:
command:
[sh, -c, 'lsmod | grep nvidia_fs']
periodSeconds: 30
initialDelaySeconds: 30
failureThreshold: 1
successThreshold: 1
timeoutSeconds: 10
{{- end }}
# Note: GDRCopy is not supported along with precompiled drivers.
# Detect this in the controller and throw an error if
Expand Down Expand Up @@ -526,15 +517,6 @@ spec:
successThreshold: 1
periodSeconds: 10
timeoutSeconds: 10
livenessProbe:
exec:
command:
[sh, -c, 'lsmod | grep gdrdrv']
periodSeconds: 30
initialDelaySeconds: 30
failureThreshold: 1
successThreshold: 1
timeoutSeconds: 10
{{- end }}
# TODO: introduce UseOpenShiftDriverToolkit field into NVIDIADriver CR?
{{- if and (.Openshift) (.Runtime.OpenshiftDriverToolkitEnabled) }}
Expand Down

0 comments on commit 5bc4874

Please sign in to comment.