Force cache build in automation #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no existing cache is found for a test run as would be the case for test automation, request a cache instance. This will cause the cache to once if any test is run by `pytest`. Signed-off-by: Jeffrey Martin <[email protected]>
leondz
reviewed
Sep 9, 2024
|
|
||
| # force a local cache file to exist when this top level import is loaded | ||
| if not os.path.isfile(_plugins.PluginCache._user_plugin_cache_filename): | ||
| _plugins.PluginCache.instance() |
There was a problem hiding this comment.
Does this not trigger _plugins.py#L63 ?
def _load_plugin_cache(self):
assert os.path.exists(
self._plugin_cache_filename
), f"{self._plugin_cache_filename} is missing or corrupt."
There was a problem hiding this comment.
Nope, the _plugin_cache_filename will always exists as part of the repo checkout, this is looking for _user_plugin_cache_filename in the user's cache dir.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no existing cache is found for a test run as would be the case for test automation, request a cache instance. This will cause the cache to build once if any test is run by
pytest.