-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/leakreplay output setting #790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, as discussed previously this change exposes the interface to attempt may need to be reworked to get away from overloading built-in methods for attributes.
* reset cache after each plugin cache test * remove fixture not needed by hitlog test Signed-off-by: Jeffrey Martin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed 22a2387 to address issue with plugin cache test side-effects.
resolves #789
any setting of
attempt.outputs
adds another output layer, so theleakreplay
's editing in_postprocess_hook()
is updated to manipulate the underlyingattempt.messages
structure instead.