Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/leakreplay output setting #790

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Conversation

leondz
Copy link
Collaborator

@leondz leondz commented Jul 18, 2024

resolves #789

any setting of attempt.outputs adds another output layer, so the leakreplay's editing in _postprocess_hook() is updated to manipulate the underlying attempt.messages structure instead.

@leondz leondz requested a review from jmartin-tech July 22, 2024 15:09
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as discussed previously this change exposes the interface to attempt may need to be reworked to get away from overloading built-in methods for attributes.

leondz and others added 2 commits July 24, 2024 09:34
* reset cache after each plugin cache test
* remove fixture not needed by hitlog test

Signed-off-by: Jeffrey Martin <[email protected]>
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed 22a2387 to address issue with plugin cache test side-effects.

@jmartin-tech jmartin-tech merged commit 54f3364 into main Jul 24, 2024
10 checks passed
@jmartin-tech jmartin-tech deleted the bugfix/leakreplay_output_setting branch July 24, 2024 15:12
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: idx out of range in leakreplay
2 participants