Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch the launch argument order #316

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

switch the launch argument order #316

wants to merge 7 commits into from

Conversation

ksimpson-work
Copy link
Contributor

@ksimpson-work ksimpson-work commented Dec 19, 2024 •
edited
Loading

close #306

flip the launch args

@ksimpson-work ksimpson-work added P0 High priority - Must do! cuda.core Everything related to the cuda.core module breaking Breaking changes are introduced labels Dec 19, 2024
@ksimpson-work ksimpson-work self-assigned this Dec 19, 2024
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 19, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang added this to the cuda.core beta 3 milestone Dec 20, 2024
@leofang
Copy link
Member

leofang commented Dec 29, 2024

/ok to test

@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work ksimpson-work marked this pull request as ready for review January 1, 2025 22:01
@ksimpson-work ksimpson-work requested a review from leofang January 1, 2025 22:01
@leofang
Copy link
Member

leofang commented Jan 2, 2025

Let's hold off merging for now. We need to wait for Bryce's update on the kernel spec.

@ksimpson-work
Copy link
Contributor Author

/ok to test

@github-actions GitHub Actions
Copy link

Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-316/


Preview will be ready when the GitHub Pages deployment is complete.

@leofang leofang marked this pull request as draft January 17, 2025 03:52
@leofang
Copy link
Member

leofang commented Jan 17, 2025

Let's hold off merging for now. We need to wait for Bryce's update on the kernel spec.

@brycelelbach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang Awaiting requested review from leofang

At least 1 approving review is required to merge this pull request.

Assignees

@ksimpson-work ksimpson-work

Labels
breaking Breaking changes are introduced cuda.core Everything related to the cuda.core module P0 High priority - Must do!
Projects
None yet
Milestone
cuda.core beta 3
Development

Successfully merging this pull request may close these issues.

Flip kernel and config positions in launch()
2 participants
@ksimpson-work @leofang