Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Radix sort stability docs #307

Merged
merged 7 commits into from
Jun 8, 2021

Conversation

alliepiper
Copy link
Collaborator

Fixes #282, extends and replaces #284.

@alliepiper alliepiper added the only: docs Documentation changes only. Doesn't need code CI. label May 12, 2021
@alliepiper alliepiper added this to the 1.13.0 milestone May 12, 2021
@alliepiper alliepiper self-assigned this May 12, 2021
For both Device and Block algorithms. Note that these do not handle
twiddling during descending sort in the same way.
@alliepiper
Copy link
Collaborator Author

@zasdfgbnm I added some more documentation to the sort algorithms in the last push, including #293. Can you review these changes to make sure they provide enough information for your needs?

* \par Supported Types
* BlockRadixSort can sort all of the built-in C++ numeric primitive types
* (<tt>unsigned char</tt>, \p int, \p double, etc.) as well as CUDA's \p __half
* half-precision floating-point type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might need to add __nv_bfloat16

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated #306 to mention bfloat16. I'll update that PR after this goes in.

Copy link
Contributor

@zasdfgbnm zasdfgbnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change of doc is very good. I like it. I left some comments. @ngimel do you have any further comments?

@alliepiper alliepiper merged commit 83e5eee into NVIDIA:main Jun 8, 2021
@alliepiper alliepiper deleted the radix_sort_stability_docs branch June 8, 2021 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
only: docs Documentation changes only. Doesn't need code CI.
Projects
None yet
3 participants