Fix instructions on building cub #298
Conversation
There was a problem hiding this comment.
This is a good point, those instructions are out of date.
I think we should just replace those instructions with a link to Thrust's CONTRIBUTING.md file. Would you mind updating this PR to do that instead?
BTW -- the long term plan here is to merge Thrust and CUB into the same repo, since they haven't been standalone projects for quite some time. NVIDA/Thrust#1283 is tracking this effort.
alliepiper
added
helps: pytorch
Thrust and CUB are tightly coupled, and just pulling CUB will cause issues when an incompatible version of Thrust is located in a toolchain's SDK. To avoid this, it's best to clone both to ensure that compatible versions are used.
|
All set -- this version describes the new preferred approach to building CUB as a developer. NVIDIA/thrust#1432 is related. Thanks again for pointing this out! Those instructions were written before the build systems were integrated, so hopefully this update will make CUB development a little easier for new contributors. |
Update Thrust's build instructions for NVIDIA/cub#298.
The building instruction in README.md doesn't work. Without cloning thrust, nvcc will try to use CUDA's built-in thrust, which will error with version not match.