This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Remove some problematic inline annotations. #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycelelbach
approved these changes
Feb 8, 2021
|
This may have had something to do with the use of a static variable internally. |
These functions started producing invalid results in CUDA 11 under certain circumstances (see issue NVIDIA/thrust#1371), and removing these hints fixes the issue. NVIDIA#260 reported that other functions in this file were also causing the same issue. These methods are not perf critical -- they don't need to be inlined.
alliepiper
force-pushed
the
bug/inline_regression/gh.thrust1371
branch
from
b86303d to
bc209e6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions started producing invalid results in CUDA 11 under
certain circumstances (see issue NVIDIA/thrust#1371), and removing
these hints fixes the issue.
cc: @ArEsKay3
Fixes NVIDIA/thrust#1371