Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements for arrow_filter_policy #654

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Minor improvements for arrow_filter_policy #654

merged 5 commits into from
Dec 10, 2024

Conversation

mhaseeb123
Copy link
Contributor

@mhaseeb123 mhaseeb123 commented Dec 10, 2024 •
edited
Loading

This PR make the hasher to arrow_filter_policy a template type for users to simply pass the hasher without specifying the Key type twice. See this comment for discussion: #653 (comment). Also update member types argument_type and hash_result_type to directly use Key and std::uint64_t for this policy.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 10, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mhaseeb123 mhaseeb123 marked this pull request as ready for review December 10, 2024 21:26
@mhaseeb123 mhaseeb123 mentioned this pull request Dec 10, 2024
Merged
3 tasks
@PointKernel
Copy link
Member

/ok to test

@PointKernel PointKernel added type: improvement Improvement / enhancement to an existing function topic: bloom_filter Issues related to bloom_filter helps: rapids Helps or needed by RAPIDS labels Dec 10, 2024
@PointKernel
Copy link
Member

/ok to test

PointKernel
PointKernel approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @mhaseeb123

@PointKernel PointKernel merged commit 096346b into NVIDIA:dev Dec 10, 2024
18 checks passed
@mhaseeb123 mhaseeb123 mentioned this pull request Dec 10, 2024
Open
@mhaseeb123 mhaseeb123 deleted the fea/minor-improvements-for-arrow-filter-policy branch December 10, 2024 23:45
@mhaseeb123 mhaseeb123 mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@sleeepyjack sleeepyjack Awaiting requested review from sleeepyjack sleeepyjack is a code owner

Assignees
No one assigned
Labels
helps: rapids Helps or needed by RAPIDS topic: bloom_filter Issues related to bloom_filter type: improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhaseeb123 @PointKernel