Add support for UNORM RGB8 output surface formats #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanteleev
reviewed
Jan 27, 2023
apanteleev
reviewed
Jan 27, 2023
...so we'll be able to do SRGB writes even if the surface format is UNORM.
res2k
force-pushed
the
swapchain-image-view-srgb
branch
from
f176f4b to
75ace54
Compare
Merged
res2k
pushed a commit
to res2k/Q2RTX
that referenced
this pull request
Oct 31, 2023
As per NVIDIA#261, this should bring results closer to what original map compilers produced on x87 FPU. May fix lightmap artifacts on some maps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can accept them during surface picking, but we need to set an SRGB format on the swapchain image view in that case.
Should help with #217, as Wayland on NVIDIA currently only exposes UNORM output surfaces.