Support PowerPC 64 Little Endian #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanteleev
reviewed
Jan 27, 2023
res2k
pushed a commit
to res2k/Q2RTX
that referenced
this pull request
Sep 21, 2023
When GMF_CLIENTNUM feature was introduced, it was expected that client POV number will only be set to valid client slot numbers in range [0, 255). Therefore, clientNum has been transmitted as a byte, with 255 (CLIENTNUM_NONE) reserved for a special case to indicate no current POV number (this has always been buggy, see below). However, one might want to set client POV to any entity >= 256, not just client entitites (to view the game from monster POV, for example). Thus, make clientNum strictly mean ‘number of POV entity minus 1’ and transmit it as a short in range [-1, MAX_EDICTS - 1). To accomodate older Q2PRO clients, reset clientNum to client slot number and zero out POV entity modelindex if clientNum is >= 255. clientNum == -1 is legal, and can happen e.g. when playing a MVD without dummy MVD observer spawned. -1 maps to 255 (CLIENTNUM_NONE) upon reading on older Q2PRO clients. This is buggy, as it will make entity 256 invisible, but there doesn't seem to be a proper fix. Mapping -1 to client slot number will make random _player_ entity invisible instead, which is worse. So don't change anything about -1. For newer Q2PRO clients clientNum == -1 will be transmitted as literal -1. This will map to entity 0 (world) and things will work as expected. This was (and still is) a huge mess. Fixes NVIDIA#260.
res2k
pushed a commit
to res2k/Q2RTX
that referenced
this pull request
Jan 21, 2024
Requested in NVIDIA#260.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Screenshots