Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDL2 to 2.26.1 #252

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Update SDL2 to 2.26.1 #252

merged 2 commits into from
Dec 28, 2022

Conversation

res2k
Copy link
Contributor

@res2k res2k commented Dec 25, 2022

Hopefully addresses #231.

@apanteleev
Copy link
Collaborator

GitHub shows that the only differences between the two versions of SDL2 is the version number - is this right? How can that fix anything?

@res2k
Copy link
Contributor Author

res2k commented Dec 28, 2022

If you manually follow the submodule directory you get here: https://github.com/libsdl-org/SDL/tree/fd196c446a476282dd457fbafe9e9b3feae3f370
It's latest commit is from Apr 2020, and by inspecting e.g. configure.ac you can see this is SDL 2.0.13.

Not sure how GH computed that diff.
Above what's shows there's the message "fd196c446a476282dd457fbafe9e9b3feae3f370 and f17058b562c8a1090c0c996b42982721ace90903 are entirely different commit histories. " - I don't think it can provide anything sensible and maybe falls back to the last commit's diff.

@apanteleev apanteleev merged commit c8b1314 into NVIDIA:master Dec 28, 2022
@apanteleev
Copy link
Collaborator

I see, thanks. I should've looked at the diffs locally / more carefully.

Merged now.

@res2k res2k deleted the update-SDL2 branch February 11, 2023 12:02
res2k pushed a commit to res2k/Q2RTX that referenced this pull request Sep 7, 2023
They will play with no distance attenuation/spatialization. Fixes NVIDIA#252.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants