Fix up vulkan initialization #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix graphics/transfer queue selection to correctly pick the same queue on platforms that dont support split queues. this also preseve's the preference for split queues. Remove unused request for sparseBindings, allows running on platforms that dont support it like mesa's ANV driver.
apanteleev
added a commit
that referenced
this pull request
Dec 14, 2022
|
Merged with an additional bug fix. Thanks! |
res2k
pushed a commit
to res2k/Q2RTX
that referenced
this pull request
Oct 31, 2023
So that effects like gamma scaling don't accumulate. Fixes NVIDIA#248.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix graphics/transfer queue selection to correctly pick the same queue on platforms that dont support split queues. this also preseve's the preference for split queues.
Remove unused request for sparseBindings, allows running on platforms that dont support it like mesa's ANV driver.
Without these fixes initialization fails either due to missing a transfer queue or missing sparseBinding on mesa's ANV driver for Arc GPUs.