Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing texture animation on bsp models (issue #185) by "animating" the frame in
load_and_transform_triangle()
.Another approach I considered was to go over each bsp model once per frame and animating the material on each primitive - think similar principle as
instance_geometry
, only for bsp models, and material animation only.I went for the
load_and_transform_triangle()
approach mainly because it's simpler.However, it may have a performance disadvantage, as the "animation" would potentially be done quite a number of times, compared for guaranteed once per frame in the approach above.
(Perhaps it would be worthwhile to implement that as well and check if there's a measurable performance difference.)