Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bsp model texture animation #187

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Conversation

res2k
Copy link
Contributor

@res2k res2k commented Feb 14, 2022

Fix missing texture animation on bsp models (issue #185) by "animating" the frame in load_and_transform_triangle().

Another approach I considered was to go over each bsp model once per frame and animating the material on each primitive - think similar principle as instance_geometry, only for bsp models, and material animation only.

I went for the load_and_transform_triangle() approach mainly because it's simpler.
However, it may have a performance disadvantage, as the "animation" would potentially be done quite a number of times, compared for guaranteed once per frame in the approach above.
(Perhaps it would be worthwhile to implement that as well and check if there's a measurable performance difference.)

@apanteleev apanteleev merged commit 73c0b7f into NVIDIA:master Feb 15, 2022
@PalmliX
Copy link

PalmliX commented Feb 15, 2022

Thanks for this res2k! I'm experimenting with some very long animations, over 100 frames, so I'll let you know about the performance.

@res2k res2k deleted the fix-bmodel-texanim branch February 16, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants