Reintroduce 'full screen blend' #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
res2k
changed the title
res2k
force-pushed
the
full-screen-blend
branch
from
dc1b03e to
1455826
Compare
|
Merged with a couple of improvements/tweaks. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the effects that's currently "lost" in RTX mode is the "full screen blend", where a color is mixed into the final image (literally, an alpha blended screen-covering rectangle). It's used for certain in-game events, eg damage received, item pickups, active effects (quad damage) - that has certainly value for the player. It's also used to give everything a murky color when underwater (so, for atmosphere of a sort).
I added the "full-screen blend" into the tone mapping step, after the final image, but before the tonemapping.
The motivation to add it there, and not the "final_blit" shader, was that I guess making it work with colors not mapped to [0,1] would be more useful if proper HDR output is ever added.