Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt_fake_roughness_threshold #9

Closed
DU-jdto opened this issue Jun 10, 2019 · 1 comment
Closed

pt_fake_roughness_threshold #9

DU-jdto opened this issue Jun 10, 2019 · 1 comment

Comments

@DU-jdto
Copy link

DU-jdto commented Jun 10, 2019

pt_fake_roughness_threshold = 1 is the 'reference' value used, and the value at which the fake specular is no longer computed in asvgf_atrous.comp. However, fake_specular_weight = smoothstep(1 - 0.05, 1 + 0.05, roughness) will still be nonzero for roughness > 0.95. In my local fork I've fixed this by replacing the two instances of this computation (one in indirect_lighting.rgen, one in asvgf_atrous.comp) with

			float fake_specular_weight = smoothstep(
				global_ubo.pt_fake_roughness_threshold,
				global_ubo.pt_fake_roughness_threshold + 0.1,
				roughness);
apanteleev added a commit that referenced this issue Jun 12, 2019
@apanteleev
Copy link
Collaborator

Fixed, closing. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants