remove nemo.collection.nlp imports from nemo2 #11904

dimapihtar · 2025-01-20T22:57:26Z

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

Signed-off-by: dimapihtar <[email protected]>

nemo/collections/llm/bert/data/core.py

nemo/collections/llm/gpt/model/base.py

Signed-off-by: dimapihtar <[email protected]>

nemo/collections/llm/quantization/quantizer.py

janekl · 2025-01-28T18:06:10Z

nemo/collections/llm/quantization/utils.py

    )
-
-    model_cfg.transformer_layer_spec = get_gpt_layer_modelopt_spec(num_experts=model_cfg.num_moe_experts)


LGTM as for changes to nemo/collections/llm/quantization ✅

Signed-off-by: dimapihtar <[email protected]>

nemo/collections/llm/bert/loss.py

nemo/collections/llm/gpt/model/gemma2.py

nemo/collections/llm/utils.py

Co-authored-by: Ananth Subramaniam <[email protected]> Signed-off-by: Dmytro Pykhtar <[email protected]>

Signed-off-by: dimapihtar <[email protected]>

Signed-off-by: Dmytro Pykhtar <[email protected]>

Signed-off-by: dimapihtar <[email protected]>

nemo/collections/llm/t5/data/core.py

Signed-off-by: dimapihtar <[email protected]>

github-actions · 2025-02-10T19:55:22Z

[🤖]: Hi @dimapihtar 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

cuichenx

GPT data and LoRA look good to me!

ericharper

LGTM. Thanks!

ericharper

Blocking until we code freeze.

ericharper

Removing block after code freeze.

* move torch_dtype_from_precision function to nemo2 Signed-off-by: dimapihtar <[email protected]> * move average_losses_across_data_parallel_group to nemo2 Signed-off-by: dimapihtar <[email protected]> * move nemo1 gemma2 modules to nemo2 Signed-off-by: dimapihtar <[email protected]> * move get_gpt_full_te_layer_autocast_spec to nemo2 Signed-off-by: dimapihtar <[email protected]> * move get_gpt_layer_modelopt_spec function to nemo2 Signed-off-by: dimapihtar <[email protected]> * remove nemo1 imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * move BertEmbeddingDataset class to nemo2 Signed-off-by: dimapihtar <[email protected]> * remove nemo1 imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * remove get_gpt_full_te_layer_autocast_spec implementation Signed-off-by: dimapihtar <[email protected]> * revert changes Signed-off-by: dimapihtar <[email protected]> * use get_gpt_layer_modelopt_spec from mcore Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * revert change Signed-off-by: dimapihtar <[email protected]> * revert changes Signed-off-by: dimapihtar <[email protected]> * move torch_dtype_from_precision to llm.utils Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * Update nemo/collections/llm/utils.py Co-authored-by: Ananth Subramaniam <[email protected]> Signed-off-by: Dmytro Pykhtar <[email protected]> * copy GPTSFTDataset to nemo2 Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * add copyright Signed-off-by: dimapihtar <[email protected]> * fix styling Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * copy T5SFTDataset to nemo2 Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * copy ParallelLinearAdapter to nemo2 Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * remove unused import Signed-off-by: dimapihtar <[email protected]> * copy BertEmbeddingDataset to nemo2 Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix import Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix import Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix TE import issue Signed-off-by: dimapihtar <[email protected]> * fix TE import Signed-off-by: dimapihtar <[email protected]> * fix circular import error Signed-off-by: dimapihtar <[email protected]> * copy logit_softcapping func to nemo2 Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * move function Signed-off-by: dimapihtar <[email protected]> * fix imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix import Signed-off-by: dimapihtar <[email protected]> * add import Signed-off-by: dimapihtar <[email protected]> * add function Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * add safe imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * use safe imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix imports Signed-off-by: dimapihtar <[email protected]> * remove unused import Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * remove unused import Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * add docstrings Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * add docstrings Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * add docstrings Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * add docstring Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix syntax error Signed-off-by: dimapihtar <[email protected]> * fix syntax error Signed-off-by: dimapihtar <[email protected]> * fix syntax error Signed-off-by: dimapihtar <[email protected]> * remove comment Signed-off-by: dimapihtar <[email protected]> * switch to mcore helpers_cpp Signed-off-by: dimapihtar <[email protected]> * fix copyright message Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * move data classes to utils Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix imports Signed-off-by: dimapihtar <[email protected]> * fix import Signed-off-by: dimapihtar <[email protected]> * fix import Signed-off-by: dimapihtar <[email protected]> * fix import Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Signed-off-by: Dmytro Pykhtar <[email protected]> Co-authored-by: dimapihtar <[email protected]> Co-authored-by: Ananth Subramaniam <[email protected]> Co-authored-by: oliver könig <[email protected]>

dimapihtar and others added 7 commits January 20, 2025 11:13

move torch_dtype_from_precision function to nemo2

f084926

Signed-off-by: dimapihtar <[email protected]>

move average_losses_across_data_parallel_group to nemo2

5fbfc88

Signed-off-by: dimapihtar <[email protected]>

move nemo1 gemma2 modules to nemo2

67d78da

Signed-off-by: dimapihtar <[email protected]>

move get_gpt_full_te_layer_autocast_spec to nemo2

d4f026b

Signed-off-by: dimapihtar <[email protected]>

move get_gpt_layer_modelopt_spec function to nemo2

9aa1183

Signed-off-by: dimapihtar <[email protected]>

remove nemo1 imports

bfca05e

Signed-off-by: dimapihtar <[email protected]>

Apply isort and black reformatting

af84c4e

Signed-off-by: dimapihtar <[email protected]>

dimapihtar changed the title ~~Dpykhtar/nemo2 transition~~ remove nemo.collection.nlp imports from nemo2 Jan 20, 2025

dimapihtar and others added 3 commits January 20, 2025 15:26

move BertEmbeddingDataset class to nemo2

5fdc333

Signed-off-by: dimapihtar <[email protected]>

remove nemo1 imports

e888a97

Signed-off-by: dimapihtar <[email protected]>

Apply isort and black reformatting

98a4cb7

Signed-off-by: dimapihtar <[email protected]>

github-advanced-security bot found potential problems Jan 20, 2025

View reviewed changes

nemo/collections/llm/bert/data/core.py Fixed Show fixed Hide fixed

nemo/collections/llm/bert/data/core.py Fixed Show fixed Hide fixed

nemo/collections/llm/bert/data/core.py Dismissed Show dismissed Hide dismissed

nemo/collections/llm/bert/data/core.py Dismissed Show dismissed Hide dismissed

ericharper reviewed Jan 21, 2025

View reviewed changes

nemo/collections/llm/gpt/model/base.py Outdated Show resolved Hide resolved

ericharper reviewed Jan 21, 2025

View reviewed changes

nemo/collections/llm/gpt/model/base.py Outdated Show resolved Hide resolved

dimapihtar and others added 7 commits January 27, 2025 05:35

remove get_gpt_full_te_layer_autocast_spec implementation

15dcfc3

Signed-off-by: dimapihtar <[email protected]>

Merge branch 'main' into dpykhtar/nemo2_transition

561e159

revert changes

5c6b278

Signed-off-by: dimapihtar <[email protected]>

use get_gpt_layer_modelopt_spec from mcore

6195bed

Signed-off-by: dimapihtar <[email protected]>

Apply isort and black reformatting

883da6b

Signed-off-by: dimapihtar <[email protected]>

revert change

a5d950b

Signed-off-by: dimapihtar <[email protected]>

revert changes

d86da30

Signed-off-by: dimapihtar <[email protected]>

dimapihtar marked this pull request as ready for review January 27, 2025 19:48

janekl reviewed Jan 28, 2025

View reviewed changes

nemo/collections/llm/quantization/quantizer.py Outdated Show resolved Hide resolved

janekl reviewed Jan 28, 2025

View reviewed changes

dimapihtar and others added 2 commits January 28, 2025 11:46

move torch_dtype_from_precision to llm.utils

8ca1047

Signed-off-by: dimapihtar <[email protected]>

Apply isort and black reformatting

533a63e

Signed-off-by: dimapihtar <[email protected]>

ananthsub reviewed Jan 29, 2025

View reviewed changes

nemo/collections/llm/bert/loss.py Show resolved Hide resolved

nemo/collections/llm/gpt/model/gemma2.py Show resolved Hide resolved

nemo/collections/llm/gpt/model/gemma2.py Show resolved Hide resolved

nemo/collections/llm/utils.py Outdated Show resolved Hide resolved

dimapihtar and others added 3 commits January 29, 2025 15:57

Update nemo/collections/llm/utils.py

75e3963

Co-authored-by: Ananth Subramaniam <[email protected]> Signed-off-by: Dmytro Pykhtar <[email protected]>

copy GPTSFTDataset to nemo2

e3c760b

Signed-off-by: dimapihtar <[email protected]>

Apply isort and black reformatting

edd59a8

Signed-off-by: dimapihtar <[email protected]>

dimapihtar and others added 5 commits February 10, 2025 05:16

fix imports

0578d38

Signed-off-by: dimapihtar <[email protected]>

Merge branch 'main' into dpykhtar/nemo2_transition

91bc1ad

Signed-off-by: Dmytro Pykhtar <[email protected]>

Apply isort and black reformatting

9a1ab5b

Signed-off-by: dimapihtar <[email protected]>

fix imports

c5d0996

Signed-off-by: dimapihtar <[email protected]>

fix import

ee36c59

Signed-off-by: dimapihtar <[email protected]>

github-advanced-security bot found potential problems Feb 10, 2025

View reviewed changes

nemo/collections/llm/t5/data/core.py Fixed Show fixed Hide fixed

fix import

c79df0d

Signed-off-by: dimapihtar <[email protected]>

dimapihtar added Run CICD and removed Run CICD labels Feb 10, 2025

dimapihtar and others added 2 commits February 10, 2025 09:38

fix import

c83e204

Signed-off-by: dimapihtar <[email protected]>

Apply isort and black reformatting

2d1f821

Signed-off-by: dimapihtar <[email protected]>

dimapihtar added Run CICD and removed Run CICD labels Feb 10, 2025

Merge branch 'main' into dpykhtar/nemo2_transition

1580c9b

dimapihtar added Run CICD and removed Run CICD labels Feb 10, 2025

dimapihtar requested review from cuichenx, ericharper and janekl February 10, 2025 21:08

cuichenx approved these changes Feb 10, 2025

View reviewed changes

ericharper approved these changes Feb 11, 2025

View reviewed changes

ericharper requested changes Feb 11, 2025

View reviewed changes

dimapihtar requested a review from ericharper February 13, 2025 18:03

ericharper approved these changes Feb 13, 2025

View reviewed changes

ericharper merged commit 8236f52 into main Feb 13, 2025
232 of 233 checks passed

ericharper deleted the dpykhtar/nemo2_transition branch February 13, 2025 18:19

cuichenx mentioned this pull request Feb 26, 2025

Fix dora import to use LLM collection #12382

Merged

8 tasks

Laplasjan107 mentioned this pull request Mar 6, 2025

[ModelOpt] Shared code in nemo.collections.llm.modelopt for ptq, prune, distill + QAT fixes #12457

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove nemo.collection.nlp imports from nemo2 #11904

remove nemo.collection.nlp imports from nemo2 #11904

dimapihtar commented Jan 20, 2025

janekl Jan 28, 2025

github-actions bot commented Feb 10, 2025

cuichenx left a comment

ericharper left a comment

ericharper left a comment

ericharper left a comment

		)

		model_cfg.transformer_layer_spec = get_gpt_layer_modelopt_spec(num_experts=model_cfg.num_moe_experts)

remove nemo.collection.nlp imports from nemo2 #11904

remove nemo.collection.nlp imports from nemo2 #11904

Conversation

dimapihtar commented Jan 20, 2025

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information

janekl Jan 28, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 10, 2025

cuichenx left a comment

Choose a reason for hiding this comment

ericharper left a comment

Choose a reason for hiding this comment

ericharper left a comment

Choose a reason for hiding this comment

ericharper left a comment

Choose a reason for hiding this comment