Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/colang nld intents #554

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Conversation

schuellc-nvidia
Copy link
Collaborator

Add support to use NLDs in Colang 2.0 user intent flows to make them more powerful (works only well with GTP-4o)

@schuellc-nvidia schuellc-nvidia requested a review from drazvan June 10, 2024 13:21
Copy link
Collaborator

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We'll need to turn this into a "full feature". This should work also when the generating user intent for unhandled user utterance is used. And we'll need to add docs as well. But we'll create a separate PR for that for the next release.

Comment on lines -129 to -131
# This is the current conversation between the user and the bot:
{{ history | colang }}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to remove the history? I think this will cause issues with contextual responses, e.g. "The first one".

or (
element_flow_state_instance = state.flow_id_states[flow_id]
if (
isinstance(flow_id, str)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flow_id will always be a string here, given the check a few lines above.

@schuellc-nvidia schuellc-nvidia merged commit 4a2a728 into develop Jun 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants