[REVIEW] Fix Sem Dedup #478
Merged
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
sarahyurick
added
gpuci
3 tasks
sarahyurick
approved these changes
Jan 9, 2025
praateekmahajan
approved these changes
Jan 13, 2025
sarahyurick
added a commit
to sarahyurick/NeMo-Curator
that referenced
this pull request
Jan 15, 2025
Signed-off-by: Sarah Yurick <[email protected]>
sarahyurick
added a commit
that referenced
this pull request
Jan 17, 2025
* add changes from #389 Signed-off-by: Sarah Yurick <[email protected]> * add scripts files Signed-off-by: Sarah Yurick <[email protected]> * add changes from #326 Signed-off-by: Sarah Yurick <[email protected]> * run black Signed-off-by: Sarah Yurick <[email protected]> * re add ParallelScoreFilter Signed-off-by: Sarah Yurick <[email protected]> * remove _MapBuckets and _Shuffle from nemo_curator path Signed-off-by: Sarah Yurick <[email protected]> * update api doc Signed-off-by: Sarah Yurick <[email protected]> * add changes from #445 Signed-off-by: Sarah Yurick <[email protected]> * Add changes from #478 Signed-off-by: Sarah Yurick <[email protected]> * final nits Signed-off-by: Sarah Yurick <[email protected]> --------- Signed-off-by: Sarah Yurick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes semdedup errors that i was seeing on machine.