-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify columns
when reading files with DocumentDataset
#311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
3 tasks
ryantwolf
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing, then we should be good.
Signed-off-by: Sarah Yurick <[email protected]>
ryantwolf
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good with me, thanks!
VibhuJawa
pushed a commit
to VibhuJawa/NeMo-Curator
that referenced
this pull request
Oct 29, 2024
* add column param Signed-off-by: Sarah Yurick <[email protected]> * read_pickle and black Signed-off-by: Sarah Yurick <[email protected]> * optional param Signed-off-by: Sarah Yurick <[email protected]> * add parquet comment Signed-off-by: Sarah Yurick <[email protected]> --------- Signed-off-by: Sarah Yurick <[email protected]>
ayushdg
pushed a commit
to ayushdg/NeMo-Curator
that referenced
this pull request
Oct 30, 2024
* add column param Signed-off-by: Sarah Yurick <[email protected]> * read_pickle and black Signed-off-by: Sarah Yurick <[email protected]> * optional param Signed-off-by: Sarah Yurick <[email protected]> * add parquet comment Signed-off-by: Sarah Yurick <[email protected]> --------- Signed-off-by: Sarah Yurick <[email protected]> Signed-off-by: Ayush Dattagupta <[email protected]>
4 tasks
vinay-raman
pushed a commit
to vinay-raman/NeMo-Curator
that referenced
this pull request
Nov 26, 2024
* add column param Signed-off-by: Sarah Yurick <[email protected]> * read_pickle and black Signed-off-by: Sarah Yurick <[email protected]> * optional param Signed-off-by: Sarah Yurick <[email protected]> * add parquet comment Signed-off-by: Sarah Yurick <[email protected]> --------- Signed-off-by: Sarah Yurick <[email protected]> Signed-off-by: Vinay Raman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180.
All of these will now work:
(1) Pandas and cuDF
read_json
do not support acolumns
parameter, so we read in the entire DataFrame and then remove unwanted columns behind the scenes.(2) Pandas and cuDF
read_parquet
both support acolumns
parameter, so we are able to take advantage of this functionality.(3) Pandas
read_pickle
(there is no cuDFread_pickle
) does not support acolumns
parameter, so we read in the entire DataFrame and then remove unwanted columns behind the scenes.(4) Following cudf.read_json, you can specify
dtype
andprune_columns=True
to only return the columns mentioned in thedtype
argument. Note that Pandas does not supportprune_columns
.