Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Edge Executor #3245

Merged
merged 10 commits into from
Feb 21, 2025
Merged

Support Edge Executor #3245

merged 10 commits into from
Feb 21, 2025

Conversation

yanchengnv
Copy link
Collaborator

Fixes # .

Description

This PR adds following features.

  • A base class (EdgeTaskExecutor) for developing executors for processing edge tasks.
  • The EdgeTaskDispatcher (ETD) that is to be installed on CP and is responsible for dispatching edge requests to the appropriate CJ. The ETD determines the right CJ based on the job's "edge_method" meta property against device's capabilities.
  • Added some test components for determining active devices from simulated device activities.
  • Added a more elegant way for registering and handling events.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@yanchengnv yanchengnv enabled auto-merge (squash) February 20, 2025 23:11
@yanchengnv
Copy link
Collaborator Author

build

@yanchengnv
Copy link
Collaborator Author

/build

nvidianz
nvidianz previously approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@nvidianz nvidianz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for our integration tests.

@nvidianz
Copy link
Collaborator

/build

@yanchengnv
Copy link
Collaborator Author

/ build

@yanchengnv
Copy link
Collaborator Author

/build

2 similar comments
@yanchengnv
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh
Copy link
Collaborator

/build

@yanchengnv yanchengnv merged commit 4bb222c into NVIDIA:main Feb 21, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvidianz nvidianz nvidianz approved these changes

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

@ZiyueXu77 ZiyueXu77 Awaiting requested review from ZiyueXu77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanchengnv @nvidianz @YuanTingHsieh