Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XGBoost example update #3242

Merged
merged 10 commits into from
Feb 21, 2025
Merged

XGBoost example update #3242

merged 10 commits into from
Feb 21, 2025

Conversation

ZiyueXu77
Copy link
Collaborator

Fixes # .

Description

Further update xgboost example to utilize JobAPI for secure xgb ones

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@ZiyueXu77
Copy link
Collaborator Author

/build

YuanTingHsieh
YuanTingHsieh reviewed Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great update, please make sure you have run them once as well, thanks!

YuanTingHsieh
YuanTingHsieh previously approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77 ZiyueXu77 merged commit 05592cc into NVIDIA:main Feb 21, 2025
20 checks passed
@ZiyueXu77 ZiyueXu77 deleted the xgb_upd branch February 21, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZiyueXu77 @YuanTingHsieh