Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add predefined log modes #3221

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Add predefined log modes #3221

merged 3 commits into from
Feb 21, 2025

Conversation

SYangster
Copy link
Collaborator

@SYangster SYangster commented Feb 13, 2025 •
edited
Loading

  • add predefined log modes ("default", "concise", and "verbose") to simulator and dynamic log config admin commands config argument
  • move simulator log_config.json to fuel/utils
  • update documentation
  • also applied to 2.5 branch ([2.5] Add predefined log modes #3237)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@SYangster SYangster force-pushed the logging_modes branch 5 times, most recently from caeb21c to b47c20d Compare February 17, 2025 09:02
@SYangster SYangster marked this pull request as ready for review February 17, 2025 09:03
@SYangster SYangster force-pushed the logging_modes branch 3 times, most recently from 60745c8 to 6e38a65 Compare February 17, 2025 09:15
@SYangster SYangster mentioned this pull request Feb 17, 2025
Closed
6 tasks
@SYangster
Copy link
Collaborator Author

/build

@SYangster SYangster force-pushed the logging_modes branch 2 times, most recently from 1fef93a to 9efc892 Compare February 17, 2025 09:37
@SYangster
Copy link
Collaborator Author

/build

@SYangster
Copy link
Collaborator Author

/build

@SYangster SYangster enabled auto-merge (squash) February 21, 2025 01:34
@SYangster SYangster merged commit f528d0d into NVIDIA:main Feb 21, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@yhwen yhwen Awaiting requested review from yhwen

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SYangster @chesterxgchen