Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate auto spills in permute #731

Merged
merged 1 commit into from
Aug 22, 2024
Merged

eliminate auto spills in permute #731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 34 additions & 6 deletions include/matx/operators/permute.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ namespace matx
}

static_assert(Rank() > 0, "PermuteOp: Rank of operator must be greater than 0.");

__MATX_INLINE__ PermuteOp(T op, const cuda::std::array<int32_t, T::Rank()> &dims) : op_(op) {

for(int32_t i = 0; i < Rank(); i++) {
Expand All @@ -85,15 +85,28 @@ namespace matx

// convert variadic type to tuple so we can read/update
cuda::std::array<index_t, Rank()> inds{indices...};
cuda::std::array<index_t, T::Rank()> ind{indices...};
cuda::std::array<index_t, Rank()> ind;
//cuda::std::array<index_t, T::Rank()> ind{indices...};

#if 0
//This causes register spills but might be faster if Rank is large
#pragma unroll
for(int32_t i = 0; i < Rank(); i++) {
ind[dims_[i]] = inds[i];
//ind[i] = inds[dims_[i]];
}
#else
#pragma unroll
// use double loop to avoid register spills
for(int32_t i = 0; i < Rank(); i++) {
#pragma unroll
for(int32_t j = 0; j < Rank(); j++) {
if(dims_[j] == i) {
ind[i] = inds[j];
}
}
}
#endif

//return op_(ind);
return cuda::std::apply(op_, ind);
}

Expand All @@ -105,12 +118,27 @@ namespace matx

// convert variadic type to tuple so we can read/update
cuda::std::array<index_t, Rank()> inds{indices...};
cuda::std::array<index_t, T::Rank()> ind{indices...};
//cuda::std::array<index_t, T::Rank()> ind{indices...};
cuda::std::array<index_t, Rank()> ind;

#if 0
//This causes register spills but might be faster if Rank is large
#pragma unroll
for(int i = 0; i < Rank(); i++) {
for(int32_t i = 0; i < Rank(); i++) {
ind[dims_[i]] = inds[i];
}
#else
#pragma unroll
// use double loop to avoid register spills
for(int32_t i = 0; i < Rank(); i++) {
#pragma unroll
for(int32_t j = 0; j < Rank(); j++) {
if(dims_[j] == i) {
ind[i] = inds[j];
}
}
}
#endif

return cuda::std::apply(op_, ind);
}
Expand Down