Skip to content

Use FMA in separable resampling. #5711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Use FMA in separable resampling. #5711

merged 1 commit into from
Nov 15, 2024

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Nov 13, 2024

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

This change improves the resampling precision by explicit use of FMA, regardless of compiler's optimizations.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

Resampling kernel tests on Blackwell.

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-4119

Signed-off-by: Michal Zientkiewicz <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [20359854]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [20359854]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [20387019]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [20387019]: BUILD FAILED

@mzient
Copy link
Contributor Author

mzient commented Nov 14, 2024

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [20407079]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [20407079]: BUILD PASSED

@mzient mzient merged commit a2d1bb1 into NVIDIA:main Nov 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants