Skip to content

Deployment cli #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Deployment cli #95

merged 3 commits into from
Mar 23, 2020

Conversation

fcollonval
Copy link
Collaborator

@markaren Here is a alternative to #89 to fix #87

I updated the example notebook. And during that update, I got the confirmation that at least with pyfmi, using simultaneously two Python FMUs is not possible 😞

@markaren
Copy link
Member

using simultaneously two Python FMUs is not possible

Not at all or is it the loggers that don't work? If it's the former we need to fix that for sure as that was something that worked before introducing the logger.

Copy link
Member

@markaren markaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

On a different note, I should probably refactor the csv stuff into a separate cli as you did with this one. pythonfmu-csvbuilder, which would allow for customization and separation of concern.

@fcollonval
Copy link
Collaborator Author

On a different note, I should probably refactor the csv stuff into a separate cli as you did with this one. pythonfmu-csvbuilder, which would allow for customization and separation of concern.

This is a great idea. One comment, should we move to a cli api like pythonfmu _command_ options rather than pythonfmu-_command_ options closer to package manager api?

@markaren
Copy link
Member

One comment, should we move to a cli api like pythonfmu command options rather than pythonfmu-command options closer to package manager api?

That might be reasonable

@fcollonval
Copy link
Collaborator Author

Ok so let's merge this and #98. And then we can do that in another PR.

@fcollonval fcollonval merged commit e9899b1 into NTNU-IHB:master Mar 23, 2020
@fcollonval fcollonval deleted the deploy-cli branch March 23, 2020 08:46
This was referenced Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bundle a requirements.txt with the FMU
2 participants