Skip to content

Bundle pythonfmu in FMU #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2020
Merged

Bundle pythonfmu in FMU #78

merged 3 commits into from
Feb 23, 2020

Conversation

markaren
Copy link
Member

This PR bundles pyhonfmu dependencies in the FMU.

Closes #77

@markaren markaren requested a review from fcollonval February 22, 2020 13:37
fcollonval
fcollonval approved these changes Feb 23, 2020
View reviewed changes
Copy link
Collaborator

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice improvement.

I added a test to check the files inclusion and simplified slightly the python code.

@markaren markaren merged commit 0803d96 into master Feb 23, 2020
@markaren markaren deleted the feature/bundle-pythonfmu-module branch February 23, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundle pythonfmu in FMU
2 participants
@markaren @fcollonval