Skip to content

Add version argparse command #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2020
Merged

Add version argparse command #74

merged 2 commits into from
Feb 20, 2020

Conversation

markaren
Copy link
Member

@markaren markaren commented Feb 20, 2020 •
edited
Loading

builder now prints the version given -v or --version.

Also removed some dead commented code.

Closes #73

@markaren markaren requested a review from fcollonval February 20, 2020 08:38
@markaren
Copy link
Member Author

Lot of failing CI runs not related to PythonFMU code lately..

fcollonval
fcollonval approved these changes Feb 20, 2020
View reviewed changes
Copy link
Collaborator

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@markaren markaren merged commit ff1af73 into master Feb 20, 2020
@markaren markaren deleted the feature/73-builder-print-version branch February 20, 2020 10:23
@fcollonval
Copy link
Collaborator

Lot of failing CI runs not related to PythonFMU code lately..

Yes, it seems the caching of the conda packages is not robust as I would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pythonfmu-builder --version
2 participants
@markaren @fcollonval