Feature/no dll logging #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still into this @fcollonval ? |
|
@markaren thanks for pinging me. Did you try to add a test case with 2 FMUs (see old commit for a basis: 82bf530)? I moved to a new company and I'm not using FMU there. May be a former colleague of mine would want to have a look @trungleduc. |
|
Thanks, your old test works fine with this PR 👍 |
Awesome, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids loading the logging dll from Python by polling log messages from the native side. This should avoid issues with loading the dll multiple times when multiple instances are loaded.
Should resolve #97