Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renew website page and structure #5

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Renew website page and structure #5

wants to merge 7 commits into from

Conversation

Catking14
Copy link
Contributor

Warning! This is (probably) a massive update

  • Remove 'Members' page in side menu
  • Move all posts to 'blog'
  • Renew 'Competitions' page to a timeline with a clickable card about each competition
  • Add independent subpage for each competition in 'competitions' page. If a competition has a blog post, it will redirect to there
  • Update the information about all competitions (except those incoming and currently updating)
  • Upload team photos to public folder

P.S. I don't know who should I assign for review since this one is pretty huge... So take it if anyone wants!
P.S.-2 It's pretty interesting to organize all prizes in over a decade!

Catking14 and others added 6 commits August 25, 2024 23:55
@Catking14
Update Website structure
d3be18a 
Add news and members pages. Also update events to new collection and create new content folder.
@Catking14
unite page item width
78d2a1e
@Catking14
Merge branch 'NTHU-SC:main' into main
f258631
@Catking14
Modify 'competitions' page architecture and remove members page
a90366e 
This commit modifies the 'competitions' page architecture to a timeline with horizontal cards. It also removes the 'members' page since there is no further usage.
some markdown files are moved to the 'blog' directory, and some new markdown files are added to test the new architecture.
@Catking14
Content template and style fixes for competitions page
56f403b 
This commit adds markdown template and picture for all competitions. Some minor css fixes have also been made.
@Catking14
Update content and style fixes
3a5cac7 
Update the information in all competitions page and fix some css style issues
@Catking14 Catking14 marked this pull request as ready for review September 7, 2024 09:30
@Catking14 Catking14 marked this pull request as draft September 7, 2024 09:35
@Catking14
Events content update
a2a3249 
Update the summer camp 2024 an winter camp 2024 events content
@Catking14
Copy link
Contributor Author

Update:

  • Added 2024 summer camp and winter camp post in 'Events'

@Catking14 Catking14 marked this pull request as ready for review September 7, 2024 11:10
@William-Mou William-Mou self-requested a review September 24, 2024 10:06
William-Mou
William-Mou requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@William-Mou William-Mou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Catking14
Please reduce the picture size to less than 1MB?

@William-Mou
Copy link
Member

Suggestions:

The competition page could include prize for each contest. by @YiPrograms
After clicking on a competition, some pages show name lists while others show content—this should be consistent.
Some events on the Event page are actually news and should be moved to the News page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@William-Mou William-Mou William-Mou requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Catking14 @William-Mou