Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref!: overhaul the commands codebase #77

Merged
merged 4 commits into from
Feb 25, 2025
Merged

ref!: overhaul the commands codebase #77

merged 4 commits into from
Feb 25, 2025

Conversation

NTBBloodbath
Copy link
Owner

@NTBBloodbath NTBBloodbath commented Feb 25, 2025 •
edited
Loading

Refactored commands:

  • new
  • build
  • serve

Note for myself: I've added a find_config_file function in the fs module. I should use it on each command later (already implemented it on serve).

@NTBBloodbath NTBBloodbath added enhancement New feature or request cmd:build Build command cmd:serve Serve command cmd:new New command labels Feb 25, 2025
@NTBBloodbath NTBBloodbath linked an issue Feb 25, 2025 that may be closed by this pull request
[Feature]: refactor codebase for maintainability #76
Closed
1 task
@NTBBloodbath NTBBloodbath marked this pull request as draft February 25, 2025 15:07
@NTBBloodbath
ref(build): overhaul the build command codebase
b7aca56 
Also move `load_metadata` and `validate_content_metadata` from `serve` command to the `shared` module to re-use them in the `build` command
@NTBBloodbath
fix(serve): gracefully prevent channel closed errors
f90b071
@NTBBloodbath
ref(new)!: overhaul the new command codebase
611266a 
BREAKING CHANGE: `--kind` now expects `norg` instead of `content` when creating norg documents
@NTBBloodbath NTBBloodbath marked this pull request as ready for review February 25, 2025 16:32
@NTBBloodbath NTBBloodbath changed the title ref: overhaul the commands codebase ref!: overhaul the commands codebase Feb 25, 2025
@NTBBloodbath NTBBloodbath merged commit 92936ba into master Feb 25, 2025
4 checks passed
@NTBBloodbath NTBBloodbath deleted the push-swxtnpxwlmlu branch February 25, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cmd:build Build command cmd:new New command cmd:serve Serve command enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: refactor codebase for maintainability
1 participant
@NTBBloodbath