-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added helix model and examples #842
Conversation
…rel/floris into v4-jf/helix-op-model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfrederik-nrel I've noted a handful of small updates (see below) that I think would clean this up.
Then, a slightly bigger question that we have discussed before would be to change the names of helix_amplitudes
and helix_frequencies
to be more generic so that they can be used in future wake mixing models (or, if even more generic, perhaps other ways of operating the turbine that are not necessarily for the purpose of wake mixing).
A couple of options would be:
wake_mixing_amplitude
andwake_mixing_frequency
blade_pitch_amplitude
andblade_pitch_frequency
pitch_induced_mixing_amplitude
andpitch_induced_mixing_frequency
Others might have suggestions for this too!
Edit: @ejsimley suggested the following, which I like:
4. active_wake_mixing_amplitude
and active_wake_mixing_frequency
Changing the names will be a little annoying as they appear in many places throughout Floris, but hopefully find and replace will be pretty effective once we decide on the names...
Edit: also after speaking with @ejsimley , it could be nice for the enable_helix_added_recovery
flag on the floris input yamls to be slightly more generic---enable_active_wake_mixing
could be an option here.
Another note is that we'll also need to figure out how to handle the helix setpoints in the |
…ction examples to floating examples folder.
This pull request was squashed into 9da4cbb. |
To do's: