Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added helix model and examples #842

Merged
merged 50 commits into from
Apr 5, 2024
Merged

Conversation

jfrederik-nrel
Copy link
Collaborator

@jfrederik-nrel jfrederik-nrel commented Mar 13, 2024

  • Added helix wake mixing model
  • Added helix turbine power loss model
  • Added examples to showcase new functionality

To do's:

  • Format code @misi9170
  • Write tests
  • Format examples
  • Add default tuning parameters for different turbines

@jfrederik-nrel jfrederik-nrel added new-feature A new feature v4 Focus of FLORIS v4 labels Mar 13, 2024
@jfrederik-nrel jfrederik-nrel added this to the v4.0 milestone Mar 13, 2024
@misi9170 misi9170 mentioned this pull request Mar 13, 2024
5 tasks
Copy link
Collaborator

@misi9170 misi9170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfrederik-nrel I've noted a handful of small updates (see below) that I think would clean this up.

Then, a slightly bigger question that we have discussed before would be to change the names of helix_amplitudes and helix_frequencies to be more generic so that they can be used in future wake mixing models (or, if even more generic, perhaps other ways of operating the turbine that are not necessarily for the purpose of wake mixing).

A couple of options would be:

  1. wake_mixing_amplitude and wake_mixing_frequency
  2. blade_pitch_amplitude and blade_pitch_frequency
  3. pitch_induced_mixing_amplitude and pitch_induced_mixing_frequency

Others might have suggestions for this too!
Edit: @ejsimley suggested the following, which I like:
4. active_wake_mixing_amplitude and active_wake_mixing_frequency

Changing the names will be a little annoying as they appear in many places throughout Floris, but hopefully find and replace will be pretty effective once we decide on the names...

Edit: also after speaking with @ejsimley , it could be nice for the enable_helix_added_recovery flag on the floris input yamls to be slightly more generic---enable_active_wake_mixing could be an option here.

floris/core/turbine/turbine.py Outdated Show resolved Hide resolved
floris/core/turbine/turbine.py Outdated Show resolved Hide resolved
floris/core/turbine/turbine.py Outdated Show resolved Hide resolved
floris/core/wake_deflection/empirical_gauss.py Outdated Show resolved Hide resolved
examples/inputs/emgauss.yaml Outdated Show resolved Hide resolved
examples/inputs/emgauss_iea_15mw.yaml Outdated Show resolved Hide resolved
examples/42_test_helix.py Outdated Show resolved Hide resolved
@misi9170
Copy link
Collaborator

Another note is that we'll also need to figure out how to handle the helix setpoints in the UncertainFlorisModel and ParallelFlorisModel. I'd say that for now, it's appropriate for those to simply raise NotImplementedErrors if helix setpoints are passed in (which I can implement), but it would be good to get others' opinions on that.

@jfrederik-nrel jfrederik-nrel requested a review from rafmudaf March 29, 2024 21:01
floris/turbine_library/nrel_5MW.yaml Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@jfrederik-nrel jfrederik-nrel marked this pull request as ready for review April 4, 2024 16:47
floris/core/solver.py Outdated Show resolved Hide resolved
@misi9170 misi9170 self-requested a review April 5, 2024 20:22
@misi9170 misi9170 merged commit 517092f into NREL:v4 Apr 5, 2024
8 checks passed
rafmudaf added a commit that referenced this pull request Apr 5, 2024
@rafmudaf
Copy link
Collaborator

rafmudaf commented Apr 5, 2024

This pull request was squashed into 9da4cbb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature A new feature v4 Focus of FLORIS v4
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants