-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use compatible-release specifier for dependency versions #748
Conversation
ok @rafmudaf all tests passing now and I got rid of the overly picky versions, good to go? |
Can you show that you tested the "docs" extra dependencies? These are not covered by the tests unless the documentation is built, and in this case it isn't |
@rafmudaf , I just cloned the latest version into a clean conda environment and ran: pip install -e ".[docs, develop]" without conflicts |
And all tests pass |
Thanks for checking that. Well done fixing this! |
Use compatible release specifiers for dependency versions
This pull request adds version specifications for the dependencies with the compatible release specifier. The change uses the latest release of each dependent version of the requirement without incrementing a major version which in semantic versioning could include breaking changes.
From the docs:
Some examples from the docs:
More concretely, if we say
numpy~=1.20
, it means that FLORIS requires Numpy to be at least v1.20 and any other larger v1 is valid but not v2.Related issue
Closes #745
Impacted areas of the software
setup.py and the dependencies chosen during installation
@kflemin