[BUGFIX] Dimension update in LayoutOptimizationBase
#1067
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1033 , there was a section of code that was missed in the dimension reduction from 5D to 4D as part of the release of Floris v4. The missed code is very much an edge case, where the minimum yaw angle is set to be a stricly positive number (and vice versa, if the maximum yaw angle is set to be strictly negative).
This PR updates that section of code, and also adds an integration test that tests for these unusual situations.
Test results, if applicable
YawOptimizationBase
(with an "axis out of bounds" error due to indexing a non-existent dimension 3---see screenshot below).YawOptimizationBase
.Notes
Screenshot of failing integration test prior to fixing dimensions:
