Add parallel solve for sample_flow_at_points
#1059
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified by @Bartdoekemeijer in #1009 , the
ParFlorisModel
did not have a parallelized version ofsample_flow_at_points()
. Instead, this method was simply inherited fromFlorisModel
, so ran in serial. This works, but does not take advantage of parallelization.This PR address the issue by adding a
sample_flow_at_points()
method toParFlorisModel
. This can be checked by using the script that @Bartdoekemeijer provided in #1009:Additional supporting information
In adding the
sample_flow_at_points()
method, I realized the mainrun()
method had a lot of unnecessarily repeated code, so I've cleaned that up a bit (and added a private method for printing timing output).Test results, if applicable
run()
functionality) passsample_flow_at_points
method