Dask help - Addd batch runner section #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tdthatcher - Tim, here's a draft for a potential addition of the SLURMRunner class. |
mselensky
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Thank you for the contribution @martin-springer ! This looks great to me; I think it will be a helpful reference for Kestrel users. I had just a couple of minor tweaks, summarized below:
Summary of requested changes
dask_slurm_runner_launcher.sh
- Remove path to log folder in --output (since folder needs to exist and this sometimes confuses people)
- Remove path to output in srun line, as it will redirect to what is specified in #SBATCH --output
- Added
--partition=shared, since I think Dask is often a great thing to run on partial node(s) - Elaborated a bit on what
MALLOC_TRIM_THRESHOLD_does
|
Forgot to say, I already committed those changes, so there is no further effort needed on your part. Will wait to hear from @yandthj on the final merge. Thanks again! |
yandthj
approved these changes
Jan 28, 2025
|
Great! Thank you both for the tweaks and getting this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a section to the Dask help. The addition explains the usage of Batch Runners on Kestrel with examples. (https://jobqueue.dask.org/en/stable/runners-overview.html)