Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add ReserveRange formulation to HydroPumpedStorage #39

Merged
merged 11 commits into from
Dec 12, 2024
Merged

Conversation

pesap
Copy link
Member

@pesap pesap commented Nov 12, 2024

No description provided.

@pesap pesap requested a review from jd-lara November 12, 2024 18:03
@pesap pesap requested a review from jarry7 November 12, 2024 18:38
@pesap
Copy link
Member Author

pesap commented Nov 12, 2024

@jd-lara , I am not sure why the test result changed for the ACPPowerModel here

test_results = Dict{Any, Float64}(ACPPowerModel => 175107.0, DCPPowerModel => 175521.0)

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.98%. Comparing base (cb5c8b2) to head (8dc1711).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/hydro_generation.jl 0.00% 13 Missing ⚠️
src/hydrogeneration_constructor.jl 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   87.61%   81.98%   -5.64%     
==========================================
  Files          10        9       -1     
  Lines         864      877      +13     
==========================================
- Hits          757      719      -38     
- Misses        107      158      +51     
Flag Coverage Δ
unittests 81.98% <6.25%> (-5.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/hydrogeneration_constructor.jl 90.76% <33.33%> (-0.59%) ⬇️
src/hydro_generation.jl 73.60% <0.00%> (-10.40%) ⬇️

... and 3 files with indirect coverage changes

---- 🚨 Try these New Features:

@jd-lara jd-lara marked this pull request as ready for review December 12, 2024 19:44
@jd-lara jd-lara merged commit 5817270 into main Dec 12, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants